Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FromFile to BinaryData #107231

Merged
merged 8 commits into from
Nov 10, 2024
Merged

Add FromFile to BinaryData #107231

merged 8 commits into from
Nov 10, 2024
+160 −56

Conversation

manandre
Copy link
Contributor

@manandre manandre commented Sep 1, 2024

Closes #106203

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 1, 2024
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
3 tasks
This was referenced Sep 5, 2024
Closed
Open
@build-analysis build-analysis bot mentioned this pull request Nov 9, 2024
Open
stephentoub
stephentoub approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@build-analysis build-analysis bot mentioned this pull request Nov 10, 2024
Open
3 tasks
@stephentoub
Copy link
Member

/ba-g unrelated timeouts

@stephentoub stephentoub merged commit 80cb458 into dotnet:main Nov 10, 2024
79 of 83 checks passed
@manandre manandre deleted the binarydata-fromfile branch November 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilinus lilinus lilinus left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add FromFile method to BinaryData
5 participants
@manandre @stephentoub @huoyaoyuan @lilinus @teo-tsirpanis